content/browser/site_per_process_browsertest.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_message_filter.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/site_per_process_browsertest.cc

diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc

index c8fa716929efe53b4a79d82206f6b7027f69d236..95ebd7537ff4c29df46d8c75d28192d696738166 100644

--- a/content/browser/site_per_process_browsertest.cc

+++ b/content/browser/site_per_process_browsertest.cc

@@ -4767,6 +4767,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,

params.previous_sibling_routing_id = MSG_ROUTING_NONE;

params.widget_params.routing_id = MSG_ROUTING_NONE;

params.widget_params.hidden = true;

+ params.replication_state.name = "name";

+ params.replication_state.unique_name = "name";

process->Send(new FrameMsg_NewFrame(params));

}

@@ -4831,6 +4833,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, ParentDetachRemoteChild) {

params.previous_sibling_routing_id = MSG_ROUTING_NONE;

params.widget_params.routing_id = widget_routing_id;

params.widget_params.hidden = true;

+ params.replication_state.name = "name";

+ params.replication_state.unique_name = "name";

process->Send(new FrameMsg_NewFrame(params));

}