third_party/WebKit/Source/web/WebFrameImplBase.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/FrameTree.cpp ('K') | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrameImplBase.h

diff --git a/third_party/WebKit/Source/web/WebFrameImplBase.h b/third_party/WebKit/Source/web/WebFrameImplBase.h

index 033ef5b6ff5de3eff32740e2a0c257949f5113ef..d82e0f362a110c39635cfc40dcf9595bc9bfff02 100644

--- a/third_party/WebKit/Source/web/WebFrameImplBase.h

+++ b/third_party/WebKit/Source/web/WebFrameImplBase.h

@@ -31,7 +31,7 @@ class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra

public:

virtual ~WebFrameImplBase();

- virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& fallbackName) = 0;

+ virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& fallbackName, const AtomicString& uniqueName) = 0;

// TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const...

virtual Frame* frame() const = 0;