third_party/WebKit/Source/web/WebFrame.cpp - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/FrameTree.cpp ('K') | « third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebFrameImplBase.h » ('j') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 5ea8859a994337fe5625a063aa2bd1263aa77c5f..faa411456d8fd0643c74dd1dd4c340ba8260f198 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -70,6 +70,7 @@ bool WebFrame::swap(WebFrame* frame)

FrameHost* host = oldFrame->host();

AtomicString name = oldFrame->tree().name();

+ AtomicString uniqueName = oldFrame->tree().uniqueName();

FrameOwner* owner = oldFrame->owner();

oldFrame->disconnectOwnerElement();

@@ -101,7 +102,7 @@ bool WebFrame::swap(WebFrame* frame)

localFrame.page()->setMainFrame(&localFrame);

}

} else {

- toWebRemoteFrameImpl(frame)->initializeCoreFrame(host, owner, name, nullAtom);

+ toWebRemoteFrameImpl(frame)->initializeCoreFrame(host, owner, name, nullAtom, uniqueName);

}

frame->toImplBase()->frame()->windowProxyManager()->setGlobals(globals);