third_party/WebKit/Source/core/page/FrameTree.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.h ('K') | « third_party/WebKit/Source/core/loader/FrameLoaderClient.h ('k') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/FrameTree.h

diff --git a/third_party/WebKit/Source/core/page/FrameTree.h b/third_party/WebKit/Source/core/page/FrameTree.h

index 37493906a646304b783ede027f16b6efaf73bbdf..9477035954752d56ec70b8bcf38ab76eea3b17ca 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.h

+++ b/third_party/WebKit/Source/core/page/FrameTree.h

@@ -70,9 +70,16 @@ public:

DECLARE_TRACE();

+ AtomicString calculateUniqueNameForNewChildFrame(

+ const AtomicString& name,

+ const AtomicString& fallbackName = nullAtom) const;

private:

Frame* deepLastChild() const;

- AtomicString uniqueChildName(const AtomicString& requestedName) const;

+ AtomicString calculateUniqueNameForChildFrame(

+ bool existingChildFrame,

+ const AtomicString& requestedName,

+ const AtomicString& fallbackName = nullAtom) const;

bool uniqueNameExists(const AtomicString& name) const;

RawPtrWillBeMember<Frame> m_thisFrame;