content/renderer/render_frame_impl.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/frame_replication_state.h ('K') | « content/public/test/mock_render_thread.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index f9cf06cd0d6133ef58aae34fc379b7ce31af3239..c600bddabd044043cb282a8f6ff2c411d9a28e16 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -438,6 +438,7 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebLocalFrame* parent,

blink::WebTreeScopeType scope,

const blink::WebString& name,

+ const blink::WebString& uniqueName,

alexmos 2016/02/10 00:46:46 nit: unique_name? (and maybe fix sandbox_flags whi

Łukasz Anforowicz 2016/02/10 22:10:51 Done.

blink::WebSandboxFlags sandboxFlags,

const blink::WebFrameOwnerProperties& frameOwnerProperties) override;

void didChangeOpener(blink::WebFrame* frame) override;

@@ -445,7 +446,8 @@ class CONTENT_EXPORT RenderFrameImpl

void frameFocused() override;

void willClose(blink::WebFrame* frame) override;

void didChangeName(blink::WebLocalFrame* frame,

- const blink::WebString& name) override;

+ const blink::WebString& name,

+ const blink::WebString& unique_name) override;

void didEnforceStrictMixedContentChecking() override;

void didChangeSandboxFlags(blink::WebFrame* child_frame,

blink::WebSandboxFlags flags) override;