xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp - Issue 1635853002: XFA: Fix a bunch of pointless returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

Issue 1635853002: XFA: Fix a bunch of pointless returns. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp b/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

index 3b991065adc916219ca0485830d4470c09a6411a..08596cb090b6576f3bb0c1bbbc5d73cd3507956b 100644

--- a/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

@@ -360,7 +360,6 @@ void CXFA_ItemLayoutProcessor::SplitLayoutItem(

void CXFA_ItemLayoutProcessor::SplitLayoutItem(FX_FLOAT fSplitPos) {

ASSERT(m_pLayoutItem);

SplitLayoutItem(m_pLayoutItem, NULL, fSplitPos);

- return;

}

IXFA_LayoutPage* CXFA_LayoutItem::GetPage() const {