country_names.cc: change SetLocaleString to take const ref instead of value

country_names.cc: change SetLocaleString to take const ref instead of value

Before the CL, SetLocaleString took a string by value and used std::move on it.

After a discussion on chromium-dev [1], passing a const ref was recognised as the preferred style in Chromium, so this CL changes it.

[1]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/string$20const$20ref/chromium-dev/ZoAfW7GXUVI/fCYjkg2JBAAJ

BUG=571610
R=isherman@chromium.org

Committed: https://crrev.com/aee53e9e6fd6d2c4877e78255d5f4416891de56e
Cr-Commit-Position: refs/heads/master@{#371617}

[vabr (Chromium), 2016-01-26 09:10:36]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 09:10:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635813003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635813003/1

[vabr (Chromium), 2016-01-26 09:12:36]

Hi Ilya,

This is the follow-up I promised you in
https://codereview.chromium.org/1582353006/diff/140001/components/autofill/co....

PTAL.

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-01-26 10:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 10:10:34]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-01-26 22:13:01]

LGTM.  Thanks for the follow-up =)

[Ilya Sherman, 2016-01-26 22:13:08]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2016-01-26 22:14:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635813003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635813003/1

[commit-bot: I haz the power, 2016-01-26 22:22:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 22:24:44]

Description was changed from

==========
country_names.cc: SetLocaleString takes const ref

SetLocaleString took a string by value and used std::move on it.

After a discussion on chromium-dev [1], pasing a const ref was recognised as
the preferred style in Chromium, so this CL changes it.

[1]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/string...

BUG=571610
R=isherman@chromium.org
==========

to

==========
country_names.cc: SetLocaleString takes const ref

SetLocaleString took a string by value and used std::move on it.

After a discussion on chromium-dev [1], pasing a const ref was recognised as
the preferred style in Chromium, so this CL changes it.

[1]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/string...

BUG=571610
R=isherman@chromium.org

Committed: https://crrev.com/aee53e9e6fd6d2c4877e78255d5f4416891de56e
Cr-Commit-Position: refs/heads/master@{#371617}
==========

[commit-bot: I haz the power, 2016-01-26 22:24:45]

Patchset 1 (id:??) landed as
https://crrev.com/aee53e9e6fd6d2c4877e78255d5f4416891de56e
Cr-Commit-Position: refs/heads/master@{#371617}

[tfarina, 2016-01-26 23:37:40]

There is a typo in the CL description, s/pasing/passing

Also, I would change the subject somehow to say that you are changing the
parameter of SetLocaleString to be by reference-to-const instead of by value.You
are saying that it takes, but currently it doesn't, sorry for the nitpicking.

[vabr (Chromium), 2016-01-27 08:27:42]

Description was changed from

==========
country_names.cc: SetLocaleString takes const ref

SetLocaleString took a string by value and used std::move on it.

After a discussion on chromium-dev [1], pasing a const ref was recognised as
the preferred style in Chromium, so this CL changes it.

[1]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/string...

BUG=571610
R=isherman@chromium.org

Committed: https://crrev.com/aee53e9e6fd6d2c4877e78255d5f4416891de56e
Cr-Commit-Position: refs/heads/master@{#371617}
==========

to

==========
country_names.cc: change SetLocaleString to take const ref instead of value

Before the CL, SetLocaleString took a string by value and used std::move on it.

After a discussion on chromium-dev [1], passing a const ref was recognised as
the preferred style in Chromium, so this CL changes it.

[1]
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/string...

BUG=571610
R=isherman@chromium.org

Committed: https://crrev.com/aee53e9e6fd6d2c4877e78255d5f4416891de56e
Cr-Commit-Position: refs/heads/master@{#371617}
==========

[vabr (Chromium), 2016-01-27 08:28:44]

On 2016/01/26 23:37:40, tfarina wrote:
> There is a typo in the CL description, s/pasing/passing
> 
> Also, I would change the subject somehow to say that you are changing the
> parameter of SetLocaleString to be by reference-to-const instead of by
value.You
> are saying that it takes, but currently it doesn't, sorry for the nitpicking.

Thanks, good points!

I edited the CL description, although that won't change the bug comment made by
bugdroid when this landed.

Cheers,
Vaclav