components/autofill/core/browser/country_names.h - Issue 1635813003: country_names.cc: change SetLocaleString to take const ref instead of value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/country_names.h

Issue 1635813003: country_names.cc: change SetLocaleString to take const ref instead of value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/country_names.h

diff --git a/components/autofill/core/browser/country_names.h b/components/autofill/core/browser/country_names.h

index a0733522ccf494d455dcc347b6cd9691f3d795fe..c54f8f93a96c2d987cd3323fa67e816e0a63cbe6 100644

--- a/components/autofill/core/browser/country_names.h

+++ b/components/autofill/core/browser/country_names.h

@@ -33,7 +33,7 @@ class CountryNames {

// Tells CountryNames, what is the application locale. Only the first supplied

// value is used, further calls result in no changes. Call this on the UI

// thread, before first using CountryNames. |locale| must not be empty.

- static void SetLocaleString(std::string locale);

+ static void SetLocaleString(const std::string& locale);

// Returns the country code corresponding to |country|, which should be a

// country code or country name localized to |locale_name|.

« no previous file with comments | « no previous file | components/autofill/core/browser/country_names.cc » ('j') | no next file with comments »