Issue 16358010: [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values

Issue 16358010: [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values (Closed)

Created:
7 years, 6 months ago by Hans Muller

Modified:
7 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, shans, alancutter (OOO until 2018), eae+blinkwatch, leviw+renderwatch, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Steve Block

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values Add support for parsing image URI values for the shape-inside and shape-outside CSS properties. Extended the ExclusionShapeValue class to support tracking the property's StyleImage value. The ExclusionShapeValue::type enums were changed from all upper case to "Intercase" by order of the style bot. The existing CSS parsing tests were extended to check URI values. BUG=244929 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151780

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -17 lines)			Patch
M	LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/exclusions/parsing-wrap-shape-outside-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+13 lines, -3 lines	0 comments	Download
M	Source/core/css/CSSParser.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/css/DeprecatedStyleBuilder.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	Source/core/page/animation/CSSPropertyAnimation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/exclusions/ExclusionShapeInfo.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/style/ExclusionShapeValue.h	View	2 chunks	+33 lines, -7 lines	1 comment	Download
M	Source/core/rendering/style/RenderStyle.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hans Muller

I've listed Eric as the reviewer because I wasn't sure who was appropriate for this ...

7 years, 6 months ago (2013-06-04 17:32:32 UTC) #1

eseidel

lgtm https://codereview.chromium.org/16358010/diff/1/Source/core/css/resolver/StyleResolver.cpp File Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/16358010/diff/1/Source/core/css/resolver/StyleResolver.cpp#newcode3661 Source/core/css/resolver/StyleResolver.cpp:3661: if (m_state.style()->shapeInside() && m_state.style()->shapeInside()->image() && m_state.style()->shapeInside()->image()->isPendingImage()) It fees ...

7 years, 6 months ago (2013-06-04 18:10:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hmuller@adobe.com/16358010/1

7 years, 6 months ago (2013-06-04 18:31:20 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11446

7 years, 6 months ago (2013-06-04 19:32:16 UTC) #4

Hans Muller

7 years, 6 months ago (2013-06-04 22:13:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r151780 (presubmit successful).

Expand Messages | Collapse Messages