Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp - Issue 16358010: [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp

Issue 16358010: [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/resolver/StyleResolver.cpp ('K') | « Source/core/rendering/exclusions/ExclusionShapeInsideInfo.cpp ('k') | Source/core/rendering/style/ExclusionShapeValue.h » ('j') | Source/core/rendering/style/ExclusionShapeValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp

diff --git a/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp b/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp

index 89d1fc1026c12e9cc453bd3dc9649df84bd1ef69..8a9f3dbab1c20acae5f09a3d2c0d9ad77dce2d44 100644

--- a/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp

+++ b/Source/core/rendering/exclusions/ExclusionShapeOutsideInfo.cpp

@@ -36,7 +36,7 @@ namespace WebCore {

bool ExclusionShapeOutsideInfo::isEnabledFor(const RenderBox* box)

{

ExclusionShapeValue* value = box->style()->shapeOutside();

- return (box->isFloatingWithShapeOutside() && value->type() == ExclusionShapeValue::SHAPE) ? value->shape() : 0;

+ return (box->isFloatingWithShapeOutside() && value->type() == ExclusionShapeValue::Shape) ? value->shape() : 0;

}

bool ExclusionShapeOutsideInfo::computeSegmentsForLine(LayoutUnit lineTop, LayoutUnit lineHeight)