Use ElementTraversal in HTMLTableRowsCollection::rowAfter()

Use ElementTraversal in HTMLTableRowsCollection::rowAfter()

Use ElementTraversal in HTMLTableRowsCollection::rowAfter() instead of
traversing manually. This makes it clearer that we are looking for Elements and
is good for performance as ContainerNode::firstChild() gets called instead of
Node::firstChild().

RoboHornet Pro benchmark is 1.7-1.8% faster with this patch on my Linux desktop.

R=adamk, eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167151

[adamk, 2014-02-13 21:42:58]

https://codereview.chromium.org/163573004/diff/1/Source/core/dom/ElementTrave...
File Source/core/dom/ElementTraversal.h (right):

https://codereview.chromium.org/163573004/diff/1/Source/core/dom/ElementTrave...
Source/core/dom/ElementTraversal.h:150: inline Element* nextSibling(const Node&
current)
This is an exact duplicate of Node::nextElementSibling().

https://codereview.chromium.org/163573004/diff/1/Source/core/html/HTMLTableRo...
File Source/core/html/HTMLTableRowsCollection.cpp (right):

https://codereview.chromium.org/163573004/diff/1/Source/core/html/HTMLTableRo...
Source/core/html/HTMLTableRowsCollection.cpp:63: for (child =
ElementTraversal::nextSibling(*previous); child; child =
ElementTraversal::nextSibling(*child)) {
Any reason not to just use Node::nextElementSibling() here and below?

[Inactive, 2014-02-13 21:51:36]

https://codereview.chromium.org/163573004/diff/1/Source/core/dom/ElementTrave...
File Source/core/dom/ElementTraversal.h (right):

https://codereview.chromium.org/163573004/diff/1/Source/core/dom/ElementTrave...
Source/core/dom/ElementTraversal.h:150: inline Element* nextSibling(const Node&
current)
On 2014/02/13 21:42:58, adamk wrote:
> This is an exact duplicate of Node::nextElementSibling().

Yes and ElementTraversal::firstWithin() is identical to
ContainerNode::firstElementChild() as well (firstElementChild() actually  uses
ElementTraversal internally already).

My plan was to make Node::nextElementSibling() use ElementTraversal internally
as well in a follow-up. I chose not to do this in this CL because this means
un-inlining Node::nextElementSibling() and it still has a lot of callers that
I'd want to move to ElementTraversal as well.

https://codereview.chromium.org/163573004/diff/1/Source/core/html/HTMLTableRo...
File Source/core/html/HTMLTableRowsCollection.cpp (right):

https://codereview.chromium.org/163573004/diff/1/Source/core/html/HTMLTableRo...
Source/core/html/HTMLTableRowsCollection.cpp:63: for (child =
ElementTraversal::nextSibling(*previous); child; child =
ElementTraversal::nextSibling(*child)) {
On 2014/02/13 21:42:58, adamk wrote:
> Any reason not to just use Node::nextElementSibling() here and below?

Personally, I'd prefer using ElementTraversal / NodeTraversal consistently on
Native side. nextElementSibling() is needed to expose to JS but I'd like it to
be a simple wrapper around ElementTraversal::nextSibling().

[adamk, 2014-02-13 21:52:57]

lgtm

ok, thanks for the explanation, I haven't been fully tuned-in to the layering
you and others have been trying to carry out in ElementTraversal.

[Inactive, 2014-02-13 21:58:40]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-13 21:59:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/163573004/1

[eseidel, 2014-02-13 22:46:22]

lgtm

Very cool.  Thank you.

[commit-bot: I haz the power, 2014-02-14 01:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 01:58:49]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Inactive, 2014-02-14 03:06:21]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-14 03:07:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/163573004/210001

[commit-bot: I haz the power, 2014-02-14 05:05:46]

Change committed as 167151