Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1635603002: Make use of CreateInterfacePtrAndBind() where appropriate (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, tzik, penghuang+watch-mandoline_chromium.org, dcheng, kinuko+watch, ben+mojo_chromium.org, tapted, cbentzel+watch_chromium.org, Matt Giuca, viettrungluu+watch_chromium.org, jam, extensions-reviews_chromium.org, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, jsbell+serviceworker_chromium.org, nhiroki, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, kalyank, rjkroege, michaeln, tfarina, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, davemoore+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of CreateInterfacePtrAndBind() where appropriate BUG=579645 TEST=none Committed: https://crrev.com/d837812ff8dc8042d328c089648cf7014a410c79 Cr-Commit-Position: refs/heads/master@{#371598}

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -111 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_intent_helper_bridge.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M components/arc/clipboard/arc_clipboard_bridge.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/arc/ime/arc_ime_ipc_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/arc/power/arc_power_bridge.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/arc/video/arc_video_bridge.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/devtools_service/devtools_agent_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/web_view/frame_devtools_agent.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/child/navigator_connect/service_port_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_session.cc View 1 chunk +1 line, -4 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/shell/application_instance.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M sql/mojo/sql_test_base.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M sql/mojo/vfs_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sky
4 years, 11 months ago (2016-01-25 23:19:09 UTC) #3
yzshen1
lgtm
4 years, 11 months ago (2016-01-25 23:49:40 UTC) #4
Ben Goodger (Google)
lgtm
4 years, 11 months ago (2016-01-26 19:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635603002/40001
4 years, 11 months ago (2016-01-26 20:10:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 21:13:47 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:15:05 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d837812ff8dc8042d328c089648cf7014a410c79
Cr-Commit-Position: refs/heads/master@{#371598}

Powered by Google App Engine
This is Rietveld 408576698