Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/proxy/proxy_resolver_factory_mojo.cc

Issue 1635603002: Make use of CreateInterfacePtrAndBind() where appropriate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager_apptest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_factory_mojo.cc
diff --git a/net/proxy/proxy_resolver_factory_mojo.cc b/net/proxy/proxy_resolver_factory_mojo.cc
index 4203eea39cdc06ec09a5ecb7b4d2cabedb1dd5d2..2070cf9bef250d0927712c09e91ab47505ccbf26 100644
--- a/net/proxy/proxy_resolver_factory_mojo.cc
+++ b/net/proxy/proxy_resolver_factory_mojo.cc
@@ -198,12 +198,10 @@ ProxyResolverMojo::Job::Job(ProxyResolverMojo* resolver,
results_(results),
callback_(callback),
binding_(this) {
- interfaces::ProxyResolverRequestClientPtr client_ptr;
- binding_.Bind(mojo::GetProxy(&client_ptr));
+ resolver_->mojo_proxy_resolver_ptr_->GetProxyForUrl(
+ mojo::String::From(url_), binding_.CreateInterfacePtrAndBind());
binding_.set_connection_error_handler(base::Bind(
&ProxyResolverMojo::Job::OnConnectionError, base::Unretained(this)));
- resolver_->mojo_proxy_resolver_ptr_->GetProxyForUrl(mojo::String::From(url_),
- std::move(client_ptr));
}
ProxyResolverMojo::Job::~Job() {
@@ -340,11 +338,9 @@ class ProxyResolverFactoryMojo::Job
callback_(callback),
binding_(this),
error_observer_(std::move(error_observer)) {
- interfaces::ProxyResolverFactoryRequestClientPtr client_ptr;
- binding_.Bind(mojo::GetProxy(&client_ptr));
on_delete_callback_runner_ = factory_->mojo_proxy_factory_->CreateResolver(
mojo::String::From(pac_script->utf16()), mojo::GetProxy(&resolver_ptr_),
- std::move(client_ptr));
+ binding_.CreateInterfacePtrAndBind());
resolver_ptr_.set_connection_error_handler(
base::Bind(&ProxyResolverFactoryMojo::Job::OnConnectionError,
base::Unretained(this)));
« no previous file with comments | « mojo/shell/application_manager_apptest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698