Rename Experimental Framework classes and concepts

third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Index: third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
diff --git a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
index 57971c90dfe3bc6f52756562099c59a384397235..058a3892449c142a32b2297bdd583f3382ddfc2b 100644
--- a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
+++ b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
@@ -20,11 +20,10 @@
 // condition=ENABLE_NAME is used for wrapping features in compile-time
 // #if ENABLE(FEATURE) guards.  These are deprecated and should all be removed.
 //
-// api_name=API_NAME is used to integrate the feature with the experimental framework, so that the feature can be
-// enabled at runtime on a per-page basis through a signed API key for the corresponding API name.
-// Declaring the api_name will cause a static method to be generated in
-// ExperimentalFeatures.h/cpp. This static method allows the feature
-// implementation to check if it is enabled for the current context.
+// experimental_feature_name=FEATURE_NAME is used to integrate the feature with the experimental framework, so that the

[chasej, 2016/01/26 16:56:53]

Earlier, I liked the "experimental_feature_name" for use as the label.  However,
after seeing it in use in this file, I think a different name might be needed. 
I think there could be confusion with "status=experimental". Often, there will
be a number of entries here with "status=experimental", but without integration
with the experimental framework (e.g. features in early development).  So, there
could be a mix of entries with status=experimental with, or without,
"experimental_feature_name=XXX".  Even with the explanatory comments, it could
appear random to developers as to which features should have the additional
configuration.

Perhaps we should use something like "origin_trial_feature_name".  That suggests
that there are origin trials associated with the feature, and the specified
feature name is used in those trials.

[iclelland, 2016/01/26 19:05:49]

I like that name -- I used 'experimental_feature_name' because it was in the
bug, and also suggested in
https://codereview.chromium.org/1541983003/patch/80001/90008.
Do we need more discussion on this?

[iclelland, 2016/01/27 18:56:46]

Done now. Renamed to origin_trial_feature_name in PS#4

+// feature can be enabled at runtime on a per-page basis through a signed token for the corresponding feature name.
+// Declaring the experimental_feature_name will cause a static method to be generated in OriginTrials.h/cpp. This static
+// method allows the feature implementation to check if it is enabled for the current context.
 
 AppBanner status=stable
 AlwaysUseComplexText status=stable
@@ -82,7 +81,7 @@ ExperimentalFramework status=test
 // The sample API is used in both unit and layout tests for the Experimental
 // Framework. Do not change this flag to stable, as it exists solely to generate
 // code used by the sample API implementation.
-ExperimentalFrameworkSampleAPI api_name=Frobulate
+ExperimentalFrameworkSampleAPI experimental_feature_name=Frobulate
 ExperimentalV8Extras status=experimental
 FastMobileScrolling
 FileAPIBlobClose status=experimental