Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Issue 1541983003: Force all experiment enabled checks to use ExperimentalFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments to explain class design and code generation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/experiments/testing/InternalsFrobulate.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
diff --git a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
index fac272dc78f7a5a3b53f5e52bdca5d8eecd3aca2..75543b339f222e373d20cf263d8e77ae869d7016 100644
--- a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
+++ b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
@@ -20,8 +20,11 @@
// condition=ENABLE_NAME is used for wrapping features in compile-time
// #if ENABLE(FEATURE) guards. These are deprecated and should all be removed.
//
-// api_name=API_NAME is used to enable the feature through the experimental framework, so that the feature can be
+// api_name=API_NAME is used to integrate the feature with the experimental framework, so that the feature can be
Rick Byers 2016/01/08 21:20:34 nit: perhaps this should be renamed to make the re
// enabled at runtime on a per-page basis through a signed API key for the corresponding API name.
+// Declaring the api_name will cause a static method to be generated in
+// ExperimentalFeatures.h/cpp. This static method allows the feature
+// implementation to check if it is enabled for the current context.
AdditiveAnimations status=experimental, depends_on=StackedCSSPropertyAnimations
AppBanner status=stable
@@ -75,6 +78,11 @@ EventListenerOptions status=experimental
ExperimentalCanvasFeatures status=test
ExperimentalContentSecurityPolicyFeatures status=experimental
ExperimentalFramework status=test
+// Define a sample API for testing integration with the Experimental Framework.
+// The sample API is used in both unit and layout tests for the Experimental
+// Framework. Do not change this flag to stable, as it exists solely to generate
+// code used by the sample API implementation.
+ExperimentalFrameworkSampleAPI api_name=Frobulate
ExperimentalV8Extras status=experimental
FastMobileScrolling
FileAPIBlobClose status=experimental
« no previous file with comments | « third_party/WebKit/Source/core/experiments/testing/InternalsFrobulate.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698