Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 1635363002: Fix double composition bug in "points" SVG attribute animation (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix double composition bug in "points" SVG attribute animation This change ensures we don't add when we should be replacing composited "points" animations when list lengths are mismatched. BUG=530436 Committed: https://crrev.com/aac5b6ab6baa013e85d883745953a4ad5b59dec9 Cr-Commit-Position: refs/heads/master@{#371721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-points-composition.html View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-points-composition-expected.txt View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
alancutter (OOO until 2018)
4 years, 11 months ago (2016-01-27 02:59:53 UTC) #2
Eric Willigers
lgtm
4 years, 11 months ago (2016-01-27 03:02:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635363002/1
4 years, 11 months ago (2016-01-27 03:22:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 04:25:20 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 04:26:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aac5b6ab6baa013e85d883745953a4ad5b59dec9
Cr-Commit-Position: refs/heads/master@{#371721}

Powered by Google App Engine
This is Rietveld 408576698