third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp - Issue 1635363002: Fix double composition bug in "points" SVG attribute animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp

Issue 1635363002: Fix double composition bug in "points" SVG attribute animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-points-composition-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp

index b63f9539c50342a8f1f730556be395f54686f8a1..896f3caecb012de89dc8d7afb73b5dcb1541be86 100644

--- a/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp

@@ -55,10 +55,10 @@ void SVGPointListInterpolationType::composite(UnderlyingValue& underlyingValue,

{

size_t startLength = toInterpolableList(underlyingValue->interpolableValue()).length();

size_t endLength = toInterpolableList(value.interpolableValue()).length();

- if (startLength != endLength)

+ if (startLength == endLength)

+ InterpolationType::composite(underlyingValue, underlyingFraction, value);

+ else

underlyingValue.set(&value);

- InterpolationType::composite(underlyingValue, underlyingFraction, value);

}

PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGPointListInterpolationType::appliedSVGValue(const InterpolableValue& interpolableValue, const NonInterpolableValue*) const

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-points-composition-expected.txt ('k') | no next file » | no next file with comments »