|
|
Created:
4 years, 11 months ago by pkotwicz Modified:
4 years, 11 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP
CAN_USE_VFP_INSTRUCTIONS was removed in GYP in
https://codereview.chromium.org/340373002
BUG=None
LOG=Y
Committed: https://crrev.com/f53d530b5f32c6e198be5b281e7fcebaa7d7f113
Cr-Commit-Position: refs/heads/master@{#33526}
Patch Set 1 #Messages
Total messages: 17 (9 generated)
pkotwicz@chromium.org changed reviewers: + rmcilroy@chromium.org
rmcilroy@ PTAL I found this as part of an audit on differences in defines between GYP and GN
lgtm
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
The CQ bit was unchecked by pkotwicz@chromium.org
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10171)
Description was changed from ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None ========== to ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y ==========
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
Message was sent while issue was closed.
Description was changed from ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y ========== to ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y ========== to ========== [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y Committed: https://crrev.com/f53d530b5f32c6e198be5b281e7fcebaa7d7f113 Cr-Commit-Position: refs/heads/master@{#33526} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f53d530b5f32c6e198be5b281e7fcebaa7d7f113 Cr-Commit-Position: refs/heads/master@{#33526} |