Chromium Code Reviews

Issue 1635123003: [GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP (Closed)

Created:
4 years, 11 months ago by pkotwicz
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[GN] Remove CAN_USE_VFP_INSTRUCTIONS define to match GYP CAN_USE_VFP_INSTRUCTIONS was removed in GYP in https://codereview.chromium.org/340373002 BUG=None LOG=Y Committed: https://crrev.com/f53d530b5f32c6e198be5b281e7fcebaa7d7f113 Cr-Commit-Position: refs/heads/master@{#33526}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -2 lines)
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments

Messages

Total messages: 17 (9 generated)
pkotwicz
rmcilroy@ PTAL I found this as part of an audit on differences in defines between ...
4 years, 11 months ago (2016-01-26 16:53:33 UTC) #2
rmcilroy
lgtm
4 years, 11 months ago (2016-01-26 16:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
4 years, 11 months ago (2016-01-26 17:10:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
4 years, 11 months ago (2016-01-26 17:10:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10171)
4 years, 11 months ago (2016-01-26 17:12:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123003/1
4 years, 11 months ago (2016-01-26 17:58:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 17:59:48 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:00:20 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f53d530b5f32c6e198be5b281e7fcebaa7d7f113
Cr-Commit-Position: refs/heads/master@{#33526}

Powered by Google App Engine