Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 340373002: [Arm]: Simplify compile-time Arm feature detection. (Closed)

Created:
6 years, 6 months ago by rmcilroy
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Rodolph Perfetta (ARM), vincent.belliard
Visibility:
Public.

Description

[Arm]: Simplify compile-time Arm feature detection. Simplify the compile time feature detection on Arm: - Define CAN_USE_XXX definitions unconditionally for all target/host toolchain combinations - Rename arm_test / ARM_TEST to arm_test_noprob / ARM_TEST_NO_FEATURE_PROBE - Don't set ARM_TEST_NO_FEATURE_PROBE implicitly on the simulator to make make simulator / native more consistent - Unify CpuFeatures::PrintTarget for simulator and native builds - Remove unecessary CAN_USE_VFP_INSTRUCTIONS definition for android (this is the default for arm_fpu=default) - Add a CpuFeatures::Probe() before calling CpuFeatures::PrintFeatures() in PrintHelp to ensure we have probed features before printing them. BUG=384474 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -139 lines) Patch
M Makefile View 1 chunk +3 lines, -4 lines 0 comments Download
M build/toolchain.gypi View 6 chunks +31 lines, -99 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +26 lines, -29 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Jakob, could you please review this CL. Vincent / Rodolph, as mentioned in crbug.com/384474, this ...
6 years, 6 months ago (2014-06-19 08:53:56 UTC) #1
Rodolph Perfetta
This works for us. Thanks.
6 years, 6 months ago (2014-06-19 09:59:56 UTC) #2
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-06-20 08:59:58 UTC) #3
rmcilroy
6 years, 6 months ago (2014-06-23 12:20:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698