Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1635123002: Avoid calling imageForCurrentFrame needlessly on SVGImageForContainer (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid calling imageForCurrentFrame needlessly on SVGImageForContainer Propagate SVGImage::isTextureBacked() through SVGImageForContainer to make https://codereview.chromium.org/1438663002 effective in more cases. BUG=552406 Committed: https://crrev.com/c12c7687127f068c644572bb6d30df0230481217 Cr-Commit-Position: refs/heads/master@{#371535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123002/1
4 years, 11 months ago (2016-01-26 16:27:37 UTC) #3
davve
PTAL
4 years, 11 months ago (2016-01-26 16:28:49 UTC) #5
fs
lgtm
4 years, 11 months ago (2016-01-26 16:31:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635123002/1
4 years, 11 months ago (2016-01-26 17:54:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 18:04:39 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:05:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c12c7687127f068c644572bb6d30df0230481217
Cr-Commit-Position: refs/heads/master@{#371535}

Powered by Google App Engine
This is Rietveld 408576698