Issue 1438663002: Avoid calling imageForCurrentFrame on SVGImage when not necessary

Issue 1438663002: Avoid calling imageForCurrentFrame on SVGImage when not necessary (Closed)

Created:
5 years, 1 month ago by Justin Novosad

Modified:
5 years, 1 month ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid calling imageForCurrentFrame on SVGImage when not necessary BUG=552406 Committed: https://crrev.com/57325d97c8a07d7347a6d9e8154860c38ca37cc6 Cr-Commit-Position: refs/heads/master@{#359092}

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	third_party/WebKit/Source/core/svg/graphics/SVGImage.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/Image.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/Image.cpp	View	1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 10 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pdr.

https://codereview.chromium.org/1438663002/diff/1/third_party/WebKit/Source/platform/graphics/Image.cpp File third_party/WebKit/Source/platform/graphics/Image.cpp (right): https://codereview.chromium.org/1438663002/diff/1/third_party/WebKit/Source/platform/graphics/Image.cpp#newcode279 third_party/WebKit/Source/platform/graphics/Image.cpp:279: return imageForCurrentFrame()->isTextureBacked(); SVGImage::imageForCurrentFrame actually draws a new frame and ...

5 years, 1 month ago (2015-11-11 06:19:45 UTC) #5

Justin Novosad

https://codereview.chromium.org/1438663002/diff/1/third_party/WebKit/Source/platform/graphics/Image.cpp File third_party/WebKit/Source/platform/graphics/Image.cpp (right): https://codereview.chromium.org/1438663002/diff/1/third_party/WebKit/Source/platform/graphics/Image.cpp#newcode279 third_party/WebKit/Source/platform/graphics/Image.cpp:279: return imageForCurrentFrame()->isTextureBacked(); On 2015/11/11 06:19:45, pdr wrote: > SVGImage::imageForCurrentFrame ...

5 years, 1 month ago (2015-11-11 15:19:45 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438663002/1

5 years, 1 month ago (2015-11-11 15:21:25 UTC) #8

commit-bot: I haz the power

5 years, 1 month ago (2015-11-12 19:57:31 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/57325d97c8a07d7347a6d9e8154860c38ca37cc6
Cr-Commit-Position: refs/heads/master@{#359092}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages