Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: content/browser/notifications/notification_message_filter.h

Issue 1634933006: Use NotificationResources instead of a bare SkBitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_message_filter.h
diff --git a/content/browser/notifications/notification_message_filter.h b/content/browser/notifications/notification_message_filter.h
index 74ecf2f441d7e672060b0b9fe4ea8c2baa15346f..a9d3e231f4dfe687d45ab54d055edea7f2640fd0 100644
--- a/content/browser/notifications/notification_message_filter.h
+++ b/content/browser/notifications/notification_message_filter.h
@@ -8,6 +8,7 @@
#include <stdint.h>
#include <map>
+#include <vector>
#include "base/callback_forward.h"
#include "base/macros.h"
@@ -17,11 +18,11 @@
#include "third_party/WebKit/public/platform/modules/notifications/WebNotificationPermission.h"
class GURL;
-class SkBitmap;
namespace content {
class BrowserContext;
+struct NotificationResources;
class PlatformNotificationContextImpl;
struct PlatformNotificationData;
class PlatformNotificationService;
@@ -57,14 +58,14 @@ class NotificationMessageFilter : public BrowserMessageFilter {
void OnShowPlatformNotification(
int notification_id,
const GURL& origin,
- const SkBitmap& icon,
- const PlatformNotificationData& notification_data);
+ const PlatformNotificationData& notification_data,
+ const NotificationResources& notification_resources);
void OnShowPersistentNotification(
int request_id,
int64_t service_worker_registration_id,
const GURL& origin,
- const SkBitmap& icon,
- const PlatformNotificationData& notification_data);
+ const PlatformNotificationData& notification_data,
+ const NotificationResources& notification_resources);
void OnGetNotifications(int request_id,
int64_t service_worker_registration_id,
const GURL& origin,
@@ -79,8 +80,8 @@ class NotificationMessageFilter : public BrowserMessageFilter {
void DidWritePersistentNotificationData(
int request_id,
const GURL& origin,
- const SkBitmap& icon,
const PlatformNotificationData& notification_data,
+ const NotificationResources& notification_resources,
bool success,
int64_t persistent_notification_id);

Powered by Google App Engine
This is Rietveld 408576698