Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.cc

Issue 1634933006: Use NotificationResources instead of a bare SkBitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_notification_manager.cc
diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.cc b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
index bf7390a1ff2eb80fb2a1ea9ec6ad846be8335f21..c0fd19fbc2b0533b55b1344997d346d52ff66dde 100644
--- a/chrome/browser/push_messaging/push_messaging_notification_manager.cc
+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
@@ -27,8 +27,8 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/notification_resources.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
-#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
@@ -43,6 +43,7 @@
using content::BrowserThread;
using content::NotificationDatabaseData;
+using content::NotificationResources;
using content::PlatformNotificationContext;
using content::PlatformNotificationData;
using content::PushMessagingService;
@@ -335,8 +336,8 @@ void PushMessagingNotificationManager::DidWriteNotificationData(
}
PlatformNotificationServiceImpl::GetInstance()->DisplayPersistentNotification(
- profile_, persistent_notification_id, origin, SkBitmap() /* icon */,
- notification_data);
+ profile_, persistent_notification_id, origin, notification_data,
+ NotificationResources());
message_handled_closure.Run();
}

Powered by Google App Engine
This is Rietveld 408576698