Issue 16348003: Merge 202233 "Allow sample rate pass through on Linux."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16348003: Merge 202233 "Allow sample rate pass through on Linux." (Closed)

Created:
7 years, 6 months ago by DaleCurtis

Modified:
7 years, 6 months ago

Reviewers:
Dale Curtis

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 202233 "Allow sample rate pass through on Linux." > Allow sample rate pass through on Linux. > > Requiring the native output sample rate to avoid glitching appears > to have just been an issue with a poor tlength choice. xians and > I resolved this prior to turning PulseAudio on by default, but left > the native sample rate requirement in at the time. > > Since "native sample rate" can change on the fly with PulseAudio > our approach of specifying FIX_RATE was incorrect. Allowing Pulse > to handle resampling lets us remove the FIX_RATE flag. It also > improves CPU usage in cases where Pulse can configure the output > device to match the requested sample rate. > > BUG=229918 > TEST=extensive manual checks for glitching. > R=xians@chromium.org > > Review URL: https://codereview.chromium.org/15957002 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204028

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -7 lines)			Patch
M	content/renderer/media/audio_renderer_mixer_manager.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/audio/pulse/audio_manager_pulse.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	media/audio/pulse/pulse_util.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r204028.

Expand Messages | Collapse Messages