Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 15957002: Allow sample rate pass through on Linux. (Closed)

Created:
7 years, 7 months ago by DaleCurtis
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Allow sample rate pass through on Linux. Requiring the native output sample rate to avoid glitching appears to have just been an issue with a poor tlength choice. xians and I resolved this prior to turning PulseAudio on by default, but left the native sample rate requirement in at the time. Since "native sample rate" can change on the fly with PulseAudio our approach of specifying FIX_RATE was incorrect. Allowing Pulse to handle resampling lets us remove the FIX_RATE flag. It also improves CPU usage in cases where Pulse can configure the output device to match the requested sample rate. BUG=229918 TEST=extensive manual checks for glitching. R=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M content/renderer/media/audio_renderer_mixer_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 2 chunks +5 lines, -1 line 0 comments Download
M media/audio/pulse/pulse_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
xians: Can you patch this in locally and see if you hear any problems? Since ...
7 years, 7 months ago (2013-05-24 00:40:12 UTC) #1
no longer working on chromium
On 2013/05/24 00:40:12, DaleCurtis wrote: > xians: Can you patch this in locally and see ...
7 years, 7 months ago (2013-05-24 08:43:03 UTC) #2
no longer working on chromium
On 2013/05/24 08:43:03, xians1 wrote: > On 2013/05/24 00:40:12, DaleCurtis wrote: > > xians: Can ...
7 years, 7 months ago (2013-05-24 13:59:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/15957002/1
7 years, 7 months ago (2013-05-24 20:32:26 UTC) #4
DaleCurtis
7 years, 7 months ago (2013-05-24 23:54:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r202233 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698