Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1634743004: mash json pref store: Handle seeks in empty files on windows. (Closed)

Created:
4 years, 11 months ago by Elliot Glaysher
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash json pref store: Handle seeks in empty files on windows. BUG=557405 Committed: https://crrev.com/c1a43e5b9c7b8e792d0ec0ce5ca299e41568c294 Cr-Commit-Position: refs/heads/master@{#371594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 11 months ago (2016-01-26 20:29:16 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 11 months ago (2016-01-26 20:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634743004/1
4 years, 11 months ago (2016-01-26 20:33:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 20:59:22 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:00:19 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1a43e5b9c7b8e792d0ec0ce5ca299e41568c294
Cr-Commit-Position: refs/heads/master@{#371594}

Powered by Google App Engine
This is Rietveld 408576698