components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc - Issue 1634743004: mash json pref store: Handle seeks in empty files on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

Issue 1634743004: mash json pref store: Handle seeks in empty files on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

diff --git a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

index ffb93b70079ea76be084d6d5bc83ce720fcdc3cf..9a11f5f870dcbcc68c808318c305f46a316b9496 100644

--- a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

+++ b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

@@ -428,6 +428,7 @@ void FilesystemJsonPrefStore::OnPreferencesFileRead(

read_only_ = true;

break;

}

+ case FileError::FAILED:

case FileError::NOT_FOUND: {

// If the file just doesn't exist, maybe this is the first run. Just

// don't pass a value.

« no previous file with comments | « no previous file | no next file » | no next file with comments »