Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 163433008: Revert 251207 "Use gpu::Mailbox instead of std:string in IPCs" (Closed)

Created:
6 years, 10 months ago by blundell
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251207 "Use gpu::Mailbox instead of std:string in IPCs" Speculative revert to determine whether it is causing the below WebViewTest.AutoSizeSW failure on the Linux Test bots (e.g., http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/30888/steps/browser_tests/logs/AutoSizeSW): FATAL:texture_layer.cc(141)] Check failed: !mailbox.IsValid() || !holder_ref_ || !mailbox.Equals(holder_ref_->holder()->mailbox()). This failure also appeared on the trybot run for this CL. > Use gpu::Mailbox instead of std:string in IPCs > > - easier to read > - safer since gpu::Mailbox is constant size and checked in the ParamTraits > > BUG=None > > Review URL: https://codereview.chromium.org/148003006 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -83 lines) Patch
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/content/browser/compositor/no_transport_image_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/frame_host/cross_process_frame_connector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/gpu/gpu_process_host_ui_shim.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc View 11 chunks +20 lines, -14 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/common/frame_param_macros.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/common/gpu/gpu_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/common/gpu/texture_image_transport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/common/gpu/texture_image_transport_surface.cc View 4 chunks +15 lines, -7 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/child_frame_compositing_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/child_frame_compositing_helper.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/gpu/command_buffer/common/mailbox.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/mailbox_manager.h View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/ui/compositor/compositor.h View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/compositor/compositor.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blundell
6 years, 10 months ago (2014-02-14 12:16:44 UTC) #1
blundell
6 years, 10 months ago (2014-02-14 12:17:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r251281 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698