Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148003006: Use gpu::Mailbox instead of std:string in IPCs (Closed)

Created:
6 years, 10 months ago by piman
Modified:
6 years, 10 months ago
Reviewers:
danakj, jschuh, blundell
CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Ian Vollick, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, cc-bugs_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Use gpu::Mailbox instead of std:string in IPCs - easier to read - safer since gpu::Mailbox is constant size and checked in the ParamTraits BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251207 R=danakj@chromium.org, jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251451

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : missing dep #

Patch Set 4 : fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -90 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M content/browser/compositor/no_transport_image_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 11 chunks +14 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/frame_param_macros.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 2 3 4 chunks +7 lines, -15 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/child_frame_compositing_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/mailbox.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
piman
danakj: please review jschuh: OWNER for IPC. You already reviewed something like this a while ...
6 years, 10 months ago (2014-02-13 01:25:44 UTC) #1
danakj
LGTM
6 years, 10 months ago (2014-02-13 19:20:35 UTC) #2
jschuh
ipc security rubberstamp lgtm: converts from string to a more narrowly defined type.
6 years, 10 months ago (2014-02-13 19:45:18 UTC) #3
piman
The CQ bit was checked by piman@chromium.org
6 years, 10 months ago (2014-02-13 20:09:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/148003006/60001
6 years, 10 months ago (2014-02-13 20:11:01 UTC) #5
piman
The CQ bit was checked by piman@chromium.org
6 years, 10 months ago (2014-02-13 21:00:21 UTC) #6
commit-bot: I haz the power
Failed to trigger a try job on mac HTTP Error 400: Bad Request
6 years, 10 months ago (2014-02-13 21:11:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/148003006/300002
6 years, 10 months ago (2014-02-13 21:12:01 UTC) #8
commit-bot: I haz the power
Change committed as 251207
6 years, 10 months ago (2014-02-14 00:36:36 UTC) #9
blundell
Reverted this CL in https://codereview.chromium.org/163433008/ as it caused WebViewTest.AutoSizeSW to fail on the Linux bots ...
6 years, 10 months ago (2014-02-14 13:36:44 UTC) #10
piman
The CQ bit was checked by piman@chromium.org
6 years, 10 months ago (2014-02-14 21:00:58 UTC) #11
piman
Fixed typo in TextureImageTransportSurface.
6 years, 10 months ago (2014-02-14 21:01:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/148003006/660001
6 years, 10 months ago (2014-02-14 21:07:24 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 22:25:40 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264603
6 years, 10 months ago (2014-02-14 22:25:40 UTC) #15
piman
6 years, 10 months ago (2014-02-15 00:16:26 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 manually as r251451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698