Reduce and limit video poster memory usage

Reduce and limit video poster memory usage

This CL does two things:
- It limits the size of poster bitmaps used by Cast to 1024*1024
- It delays getting the poster bitmap until it is actually needed, and
disposes of bitmaps when Cast has finished with them. This means that
there should never be more than one poster bitmap in memory at a time
(although there may be C++ and Java copies of it.).

This should drastically reduce the number of OOM crashes we get from
poster bitmaps.

BUG=529871
Committed: https://crrev.com/fee9a5ecb3ca55d96209e15a789bd184b439f943
Cr-Commit-Position: refs/heads/master@{#371541}

[aberent, 2016-01-26 16:55:18]

aberent@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-01-26 17:00:17]

Very neat! lgtm!

https://codereview.chromium.org/1634173002/diff/1/chrome/browser/media/androi...
File chrome/browser/media/android/remote/remote_media_player_manager.cc (right):

https://codereview.chromium.org/1634173002/diff/1/chrome/browser/media/androi...
chrome/browser/media/android/remote/remote_media_player_manager.cc:114:
poster_urls_[player_id] = url;
Do we need to clean this up? E.g. can the url from one player be accidentally
reused for another player with the same id?

[aberent, 2016-01-26 17:21:08]

The CQ bit was checked by aberent@chromium.org

[aberent, 2016-01-26 17:21:08]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1634173002/#ps20001
(title: "Fix empty poster handling. Also clear poster url when player
destroyed.")

[aberent, 2016-01-26 17:21:18]

https://codereview.chromium.org/1634173002/diff/1/chrome/browser/media/androi...
File chrome/browser/media/android/remote/remote_media_player_manager.cc (right):

https://codereview.chromium.org/1634173002/diff/1/chrome/browser/media/androi...
chrome/browser/media/android/remote/remote_media_player_manager.cc:114:
poster_urls_[player_id] = url;
On 2016/01/26 17:00:17, whywhat wrote:
> Do we need to clean this up? E.g. can the url from one player be accidentally
> reused for another player with the same id?

Done. Not sure it is actually necessary (I don't think ids are reused within the
same manager) but probably a good idea.

[commit-bot: I haz the power, 2016-01-26 17:21:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1634173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1634173002/20001

[commit-bot: I haz the power, 2016-01-26 18:15:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 18:16:44]

Description was changed from

==========
Reduce and limit video poster memory usage

This CL does two things:
- It limits the size of poster bitmaps used by Cast to 1024*1024
- It delays getting the poster bitmap until it is actually needed, and
disposes of bitmaps when Cast has finished with them. This means that
there should never be more than one poster bitmap in memory at a time
(although there may be C++ and Java copies of it.).

This should drastically reduce the number of OOM crashes we get from
poster bitmaps.

BUG=529871
==========

to

==========
Reduce and limit video poster memory usage

This CL does two things:
- It limits the size of poster bitmaps used by Cast to 1024*1024
- It delays getting the poster bitmap until it is actually needed, and
disposes of bitmaps when Cast has finished with them. This means that
there should never be more than one poster bitmap in memory at a time
(although there may be C++ and Java copies of it.).

This should drastically reduce the number of OOM crashes we get from
poster bitmaps.

BUG=529871

Committed: https://crrev.com/fee9a5ecb3ca55d96209e15a789bd184b439f943
Cr-Commit-Position: refs/heads/master@{#371541}
==========

[commit-bot: I haz the power, 2016-01-26 18:16:44]

Patchset 2 (id:??) landed as
https://crrev.com/fee9a5ecb3ca55d96209e15a789bd184b439f943
Cr-Commit-Position: refs/heads/master@{#371541}