Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3796)

Unified Diff: chrome/browser/media/android/remote/remote_media_player_manager.h

Issue 1634173002: Reduce and limit video poster memory usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix empty poster handling. Also clear poster url when player destroyed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/remote/remote_media_player_manager.h
diff --git a/chrome/browser/media/android/remote/remote_media_player_manager.h b/chrome/browser/media/android/remote/remote_media_player_manager.h
index e0cef391542cbf4117170561d59772f9563822c4..fea7caa9d9e44af35c80bc5a2790bf61ec734817 100644
--- a/chrome/browser/media/android/remote/remote_media_player_manager.h
+++ b/chrome/browser/media/android/remote/remote_media_player_manager.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_MEDIA_ANDROID_REMOTE_REMOTE_MEDIA_PLAYER_MANAGER_H_
#include <set>
+#include <unordered_map>
#include <vector>
#include "base/macros.h"
@@ -105,12 +106,15 @@ class RemoteMediaPlayerManager : public content::BrowserMediaPlayerManager {
void SwapCurrentPlayer(int player_id);
+ void FetchPosterBitmap(int player_id);
+
// Contains the alternative players that are not currently in use, i.e. the
// remote players for videos that are playing locally, and the local players
// for videos that are playing remotely.
ScopedVector<media::MediaPlayerAndroid> alternative_players_;
std::set<int> players_playing_remotely_;
+ std::unordered_map<int, GURL> poster_urls_;
base::WeakPtrFactory<RemoteMediaPlayerManager> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698