Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1634133003: Condense Image::hasRelative{Width,Height}() into one (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fs, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, vmpstr+blinkwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, loading-reviews+fetch_chromium.org, Nate Chapin, danakj+watch_chromium.org, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Condense Image::hasRelative{Width,Height}() into one Image::hasRelative{Width,Height} always return the same result so there is no need for two functions. Since https://codereview.chromium.org/26390004 there is no reason to have these separate since the SVGImage implementations are gone. BUG=581357 Committed: https://crrev.com/c0c3ae2860b769ca9f158ccc455d58de5d599339 Cr-Commit-Position: refs/heads/master@{#371764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -56 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleInvalidImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634133003/1
4 years, 11 months ago (2016-01-26 16:16:42 UTC) #2
davve
Small clean-up. PTAL.
4 years, 11 months ago (2016-01-26 16:18:20 UTC) #4
pdr.
On 2016/01/26 at 16:18:20, davve wrote: > Small clean-up. PTAL. LGTM!
4 years, 11 months ago (2016-01-26 18:26:53 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/164510)
4 years, 11 months ago (2016-01-26 18:49:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1634133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1634133003/1
4 years, 11 months ago (2016-01-27 08:42:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 09:59:44 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 10:00:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0c3ae2860b769ca9f158ccc455d58de5d599339
Cr-Commit-Position: refs/heads/master@{#371764}

Powered by Google App Engine
This is Rietveld 408576698