Support for constructor references in constant serializer and prelinker.

Support for constructor references in constant serializer and prelinker.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b0836ee7b9d88078f5bac07be69c64d4fe7ce80e

[Paul Berry, 2016-01-26 00:47:22]

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:47: final Map<String, _Meaning>
namespace;
Instead of adding _ClassMeaning as a new class, I wonder if it would be better
to rename _PrefixMeaning to something more general (_MeaningWithNamespace
maybe?) and use it for both cases.

That would let us simplify the code down at line 408.

Your call, though.

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_ast.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:38: return new
EntityRefBuilder(reference: nameRef);
I don't understand why there are three separate return statements in this
function.  Aren't there only two cases (named and unnamed constructors)?

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:4623: class _PrefixExpectation
{
Some documentation for this class would be really helpful.

[scheglov, 2016-01-26 04:34:49]

PTAL

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:47: final Map<String, _Meaning>
namespace;
On 2016/01/26 00:47:21, Paul Berry wrote:
> Instead of adding _ClassMeaning as a new class, I wonder if it would be better
> to rename _PrefixMeaning to something more general (_MeaningWithNamespace
> maybe?) and use it for both cases.
> 
> That would let us simplify the code down at line 408.
> 
> Your call, though.

It could work, but in _PrefixMeaning all its _Meaning properties are static, and
for _ClassMeaning they are almost all different. We could add a common
superclass or a two constructors in one class. I don't know... I'm leaving it as
it for now.

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_ast.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_ast.dart:38: return new
EntityRefBuilder(reference: nameRef);
On 2016/01/26 00:47:21, Paul Berry wrote:
> I don't understand why there are three separate return statements in this
> function.  Aren't there only two cases (named and unnamed constructors)?

Fixed.
Now we record only explicit names and let the client to decide what to do with a
class or constructor reference.

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1633863002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:4623: class _PrefixExpectation
{
On 2016/01/26 00:47:21, Paul Berry wrote:
> Some documentation for this class would be really helpful.

Done.

[Paul Berry, 2016-01-26 12:43:56]

lgtm, thanks!

[scheglov, 2016-01-26 16:23:16]

Description was changed from

==========
Support for constructor references in constant serializer and prelinker.

R=paulberry@google.com
BUG=
==========

to

==========
Support for constructor references in constant serializer and prelinker.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b0836ee7b9d88078f5bac07be69c64d4fe7ce80e
==========

[scheglov, 2016-01-26 16:23:17]

Committed patchset #2 (id:20001) manually as
b0836ee7b9d88078f5bac07be69c64d4fe7ce80e (presubmit successful).