Support for constructor references in constant serializer and prelinker.

pkg/analyzer/lib/src/summary/summarize_ast.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library serialization.summarize_ast;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
@@ skipping 10 matching lines @@
 
 /**
  * Instances of this class keep track of intermediate state during
  * serialization of a single constant [Expression].
  */
 class _ConstExprSerializer extends AbstractConstExprSerializer {
   final _SummarizeAstVisitor visitor;
 
   _ConstExprSerializer(this.visitor);
 
+  @override
+  EntityRefBuilder serializeConstructorName(ConstructorName constructor) {
+    TypeName type = constructor.type;
+    Identifier typeName = type.name;
+    EntityRefBuilder typeBuilder = serializeType(type);
+    if (typeName is SimpleIdentifier) {
+      int nameRef = visitor.serializeReference(typeBuilder.reference, '');
+      return new EntityRefBuilder(reference: nameRef);

[Paul Berry, 2016/01/26 00:47:21]

I don't understand why there are three separate return statements in this
function.  Aren't there only two cases (named and unnamed constructors)?

[scheglov, 2016/01/26 04:34:49]

Fixed.
Now we record only explicit names and let the client to decide what to do with a
class or constructor reference.

+    } else if (typeName is PrefixedIdentifier) {
+      if (constructor.name == null) {
+        return typeBuilder;
+      } else {
+        String name = constructor.name.name;
+        int nameRef = visitor.serializeReference(typeBuilder.reference, name);
+        return new EntityRefBuilder(reference: nameRef);
+      }
+    } else {
+      throw new StateError(
+          'Unexpected identifier type: ${typeName.runtimeType}');
+    }
+  }
+
   EntityRefBuilder serializeIdentifier(Identifier identifier) {
     EntityRefBuilder b = new EntityRefBuilder();
     if (identifier is SimpleIdentifier) {
       b.reference = visitor.serializeReference(null, identifier.name);
     } else if (identifier is PrefixedIdentifier) {
       int prefix = visitor.serializeReference(null, identifier.prefix.name);
       b.reference =
           visitor.serializeReference(prefix, identifier.identifier.name);
     } else {
       throw new StateError(
@@ skipping 808 matching lines @@
 /**
  * A [_TypeParameterScope] is a [_Scope] which defines [_ScopedTypeParameter]s.
  */
 class _TypeParameterScope extends _Scope {
   /**
    * Get the number of [_ScopedTypeParameter]s defined in this
    * [_TypeParameterScope].
    */
   int get length => _definedNames.length;
 }