Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1633733004: Use browser top chrome material design by default on Chrome OS (Closed)

Created:
4 years, 11 months ago by tdanderson
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use browser top chrome material design by default on Chrome OS Change the default value of the --top-chrome-md flag to map to 'material' on Chrome OS, and remain as 'non-material' on all other platforms. On Chrome OS this will impact the assets, layout, theming, and visual feedback of mouse/touch interactions across the browser's UI surfaces, namely: * Tabstrip * Toolbar * Bookmarks bar * Omnibox dropdown * Incognito mode * Bubbles * Infobars This CL does NOT make any changes to UI on other platforms or non-browser UI on Chrome OS (shelf, tray, etc). Furthermore, this CL should not introduce any regressions in functionality. Please use the label Proj-MaterialDesign-NativeUI when filing bugs in crbug. BUG=581143, 575270 TEST=MaterialDesignControllerTest.* Committed: https://crrev.com/5a526d962388ff378514fcf3e1ac75d44c964129 Cr-Commit-Position: refs/heads/master@{#371609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M ui/base/material_design/material_design_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/material_design/material_design_controller.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M ui/base/material_design/material_design_controller_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tdanderson
Scott, can you please take a look? This has approval from PM and design to ...
4 years, 11 months ago (2016-01-26 18:48:59 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-26 21:41:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633733004/1
4 years, 11 months ago (2016-01-26 21:43:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:49:39 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:51:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a526d962388ff378514fcf3e1ac75d44c964129
Cr-Commit-Position: refs/heads/master@{#371609}

Powered by Google App Engine
This is Rietveld 408576698