Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: ui/base/material_design/material_design_controller.cc

Issue 1633733004: Use browser top chrome material design by default on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/material_design/material_design_controller.cc
diff --git a/ui/base/material_design/material_design_controller.cc b/ui/base/material_design/material_design_controller.cc
index cc08469b89d7831b95b8cc90d9f425b22eed7655..baf4fa19dd1a6c432d185496e2509f1fd81fe719 100644
--- a/ui/base/material_design/material_design_controller.cc
+++ b/ui/base/material_design/material_design_controller.cc
@@ -28,6 +28,14 @@ bool MaterialDesignController::IsModeMaterial() {
GetMode() == Mode::MATERIAL_HYBRID;
}
+MaterialDesignController::Mode MaterialDesignController::DefaultMode() {
+#if defined(OS_CHROMEOS)
+ return Mode::MATERIAL_NORMAL;
+#else
+ return Mode::NON_MATERIAL;
+#endif // defined(OS_CHROMEOS)
+}
+
void MaterialDesignController::InitializeMode() {
#if !defined(ENABLE_TOPCHROME_MD)
SetMode(Mode::NON_MATERIAL);
@@ -43,10 +51,12 @@ void MaterialDesignController::InitializeMode() {
} else if (switch_value == switches::kTopChromeMDNonMaterial) {
SetMode(Mode::NON_MATERIAL);
} else {
- LOG(ERROR) << "Invalid value='" << switch_value
- << "' for command line switch '" << switches::kTopChromeMD
- << "'.";
- SetMode(Mode::NON_MATERIAL);
+ if (!switch_value.empty()) {
+ LOG(ERROR) << "Invalid value='" << switch_value
+ << "' for command line switch '" << switches::kTopChromeMD
+ << "'.";
+ }
+ SetMode(DefaultMode());
}
#endif // !defined(ENABLE_TOPCHROME_MD)
}
« no previous file with comments | « ui/base/material_design/material_design_controller.h ('k') | ui/base/material_design/material_design_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698