Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1633623003: Revert of Enable handle verifier for tests and add some tests. (Closed)

Created:
4 years, 11 months ago by oshima
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable handle verifier for tests and add some tests. (patchset #7 id:120001 of https://codereview.chromium.org/1580873003/ ) Reason for revert: A lot of test are crashing on DrMemory x64 bot, so I'm reverting this speculatively. I'll reland this if it didn't help. Original issue's description: > Enable handle verifier for tests and add some tests. > > BUG=571304 > > Committed: https://crrev.com/ff6cc3d794e1285c68f74ec9ae6d59dc3e523d5b > Cr-Commit-Position: refs/heads/master@{#371075} TBR=cpu@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571304, 580795 Committed: https://crrev.com/d22a80067f3e4afe64a4e638579b8030d4c95248 Cr-Commit-Position: refs/heads/master@{#371330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -96 lines) Patch
M base/test/test_suite.cc View 2 chunks +1 line, -12 lines 0 comments Download
M base/win/scoped_handle.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/win/scoped_handle.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/win/scoped_handle_unittest.cc View 2 chunks +0 lines, -76 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
oshima
Created Revert of Enable handle verifier for tests and add some tests.
4 years, 11 months ago (2016-01-25 20:47:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633623003/1
4 years, 11 months ago (2016-01-25 20:50:42 UTC) #2
Will Harris
On 2016/01/25 20:50:42, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 11 months ago (2016-01-25 20:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633623003/1
4 years, 11 months ago (2016-01-25 21:03:50 UTC) #4
Will Harris
lgtm but I hope this can be reproduced locally or else this will be a ...
4 years, 11 months ago (2016-01-25 21:04:03 UTC) #5
oshima
On 2016/01/25 21:04:03, Will Harris wrote: > lgtm but I hope this can be reproduced ...
4 years, 11 months ago (2016-01-25 21:24:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633623003/1
4 years, 11 months ago (2016-01-25 21:34:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633623003/1
4 years, 11 months ago (2016-01-25 22:03:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 22:11:56 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:14:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d22a80067f3e4afe64a4e638579b8030d4c95248
Cr-Commit-Position: refs/heads/master@{#371330}

Powered by Google App Engine
This is Rietveld 408576698