Issue 16336017: [NaCl SDK] Make verification failures a little easier to read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16336017: [NaCl SDK] Make verification failures a little easier to read. (Closed)

Created:
7 years, 6 months ago by binji

Modified:
7 years, 6 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Make verification failures a little easier to read. BUG=245011 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204047

Patch Set 2 : feedback #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -9 lines)			Patch
M	native_client_sdk/src/build_tools/build_sdk.py	View	1	1 chunk	+24 lines, -3 lines	0 comments	Download
M	native_client_sdk/src/build_tools/sdk_files.list	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	native_client_sdk/src/build_tools/verify_filelist.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

binji

PTAL -- I added the EXE_EXT change, so this depends on the ragel ncval CL.

7 years, 6 months ago (2013-06-03 19:18:37 UTC) #1

Sam Clegg

lgtm https://codereview.chromium.org/16336017/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/16336017/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode770 native_client_sdk/src/build_tools/build_sdk.py:770: print 'to test.' Don't you need to actually ...

7 years, 6 months ago (2013-06-03 19:31:44 UTC) #2

binji

7 years, 6 months ago (2013-06-04 21:14:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r204047 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16336017: [NaCl SDK] Make verification failures a little easier to read. (Closed)

Description

Patch Set 1 #

Patch Set 2 : feedback #

Messages