Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 16336017: [NaCl SDK] Make verification failures a little easier to read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/sdk_files.list » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index d856b04f99798aedd42793e4f9c7605f1e0ef2c1..75e2f88024dcc1c8f7ee6fc1242afa612eb9ae70 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -751,9 +751,30 @@ def GenerateNotice(fileroot, output_filename='NOTICE', extra_files=None):
def BuildStepVerifyFilelist(pepperdir, platform):
buildbot_common.BuildStep('Verify SDK Files')
- verify_filelist.Verify(platform, os.path.join(SCRIPT_DIR, 'sdk_files.list'),
- pepperdir)
- print 'OK'
+ file_list_path = os.path.join(SCRIPT_DIR, 'sdk_files.list')
+ try:
+ verify_filelist.Verify(platform, file_list_path, pepperdir)
+ print 'OK'
+ except verify_filelist.ParseException, e:
+ buildbot_common.ErrorExit('Parsing sdk_files.list failed:\n\n%s' % e)
+ except verify_filelist.VerifyException, e:
+ file_list_rel = os.path.relpath(file_list_path)
+ verify_filelist_py = os.path.splitext(verify_filelist.__file__)[0] + '.py'
+ verify_filelist_py = os.path.relpath(verify_filelist_py)
+ pepperdir_rel = os.path.relpath(pepperdir)
+
+ msg = """\
+SDK verification failed:
+
+%s
+Add/remove files from %s to fix.
+
+Run:
+ ./%s %s %s
+to test.""" % (e, file_list_rel, verify_filelist_py, file_list_rel,
+ pepperdir_rel)
+ buildbot_common.ErrorExit(msg)
+
def BuildStepTarBundle(pepper_ver, tarfile):
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/sdk_files.list » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698