Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 16336011: Revert 203489 "Replace JSON (de)serialization of extension messa..." (Closed)

Created:
7 years, 6 months ago by tonyg
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 203489 "Replace JSON (de)serialization of extension messa..." Breaks page_cycler_2012Q2-netsim benchmark. BUG=246213 > Replace JSON (de)serialization of extension messages with direct Value pickling. > > BUG=55316 > R=mpcomplete@chromium.org > TBR=cdn@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/16226004 TBR=kalman@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -199 lines) Patch
M trunk/src/chrome/browser/extensions/api/messaging/extension_message_port.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/extension_message_port.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/message_service.h View 4 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/message_service.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/native_message_port.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/native_message_port.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/native_message_process_host.h View 2 chunks +4 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/native_message_process_host.cc View 3 chunks +1 line, -30 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 4 chunks +26 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/extensions/message_handler.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/message_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/extension_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/extension_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/miscellaneous_bindings.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/miscellaneous_bindings.cc View 5 chunks +34 lines, -74 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/miscellaneous_bindings.js View 3 chunks +10 lines, -2 lines 0 comments Download
MM trunk/src/chrome/test/data/devtools/extensions/devtools_messaging/devtools.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
7 years, 6 months ago (2013-06-03 17:35:35 UTC) #1
tonyg
7 years, 6 months ago (2013-06-03 17:36:19 UTC) #2
tonyg
Seems like it is time to get the tree green again and continue investigating this ...
7 years, 6 months ago (2013-06-03 19:05:01 UTC) #3
not at google - send to devlin
damn it. the problem is actually https://chromiumcodereview.appspot.com/10837066 a quick fix without reverting this patch would ...
7 years, 6 months ago (2013-06-03 19:07:00 UTC) #4
tonyg
On 2013/06/03 19:07:00, kalman wrote: > damn it. the problem is actually https://chromiumcodereview.appspot.com/10837066 Is that ...
7 years, 6 months ago (2013-06-03 19:12:28 UTC) #5
tonyg
7 years, 6 months ago (2013-06-03 19:26:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r203753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698