Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: trunk/src/chrome/browser/extensions/api/messaging/native_message_port.cc

Issue 16336011: Revert 203489 "Replace JSON (de)serialization of extension messa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/messaging/native_message_port.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/messaging/native_message_port.cc (revision 203729)
+++ trunk/src/chrome/browser/extensions/api/messaging/native_message_port.cc (working copy)
@@ -4,8 +4,6 @@
#include "chrome/browser/extensions/api/messaging/native_message_port.h"
-#include "base/bind.h"
-#include "base/json/json_writer.h"
#include "chrome/browser/extensions/api/messaging/native_message_process_host.h"
#include "content/public/browser/browser_thread.h"
@@ -20,20 +18,12 @@
content::BrowserThread::IO, FROM_HERE, native_process_);
}
-void NativeMessagePort::DispatchOnMessage(scoped_ptr<base::ListValue> message,
+void NativeMessagePort::DispatchOnMessage(const std::string& message,
int target_port_id) {
- std::string message_as_json;
- if (!message->empty()) {
- DCHECK_EQ(1u, message->GetSize());
- base::Value* value = NULL;
- message->Get(0, &value);
- base::JSONWriter::Write(value, &message_as_json);
- }
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&NativeMessageProcessHost::Send,
- base::Unretained(native_process_),
- message_as_json));
+ base::Unretained(native_process_), message));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698