Chromium Code Reviews Chromium Code Reviews
Issue 1633553002:
Change in focus with movement of Arrow keys for RTL radio buttons (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html b/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html |
| index 1ae468faa1a1861af63fb6b0b74e7696798c953d..3113af0fd6c27e8015427b9e800f549e06191056 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html |
| +++ b/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html |
| @@ -1,5 +1,8 @@ |
| <!DOCTYPE html> |
| <html> |
| +<head> |
| + <meta charset="UTF-16"> |
|
tkent
2016/02/08 23:32:26
This file isn't UTF-16. Please remove it.
I don't
chakshu
2016/02/10 10:17:02
Done.
|
| +</head> |
| <body> |
| <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=32013">https://bugs.webkit.org/show_bug.cgi?id=32013</a>. |
| @@ -20,6 +23,16 @@ should still be dispatched but the checked radio should not change. |
| <input type=radio name=bbb value=e onchange="handleChange(event)" onclick="handleClick(event)">e |
| <input type=radio name=bbb value=f onchange="handleChange(event)" onclick="handleClick(event)">f |
| +<p>Test for <a href="https://code.google.com/p/chromium/issues/detail?id=556677">https://code.google.com/p/chromium/issues/detail?id=556677</a>. |
| + |
| +<p>For manual testing, focus a radio button in the first group and use the arrow keys. Changing the |
| +radio button should fire change events in the direction of left to right. |
| +<div dir="auto"> |
|
tkent
2016/02/08 23:32:26
We'd like to test RTL, so please specify dir=rtl.
chakshu
2016/02/10 10:17:02
Done.
|
| +<p> |
|
tkent
2016/02/08 23:32:26
This "<p>" looks unnecessary.
chakshu
2016/02/10 10:17:02
This is to separate the radio buttons from the Ass
|
| +<input type="radio" value="אחד" onchange="handleChange(event)" name="r">אחד |
| +<input type="radio" value="שני" onchange="handleChange(event)" name="r">שני |
| +<input type="radio" value="שלוש" onchange="handleChange(event)" name="r">שלוש |
| +</div> |
| <pre id=out></pre> |
| <script> |
| @@ -85,6 +98,10 @@ if (window.eventSender) { |
| eventSender.keyDown('downArrow'); |
| eventSender.keyDown('downArrow'); |
| + getRadio('אחד').focus(); |
|
tkent
2016/02/08 23:32:26
Please move this block just before the first |asse
chakshu
2016/02/10 10:17:02
Done.
|
| + eventSender.keyDown('rightArrow'); |
| + eventSender.keyDown('rightArrow'); |
| + |
| assertNotChecked('a'); |
| assertNotChecked('b'); |
| assertChecked('c'); |
| @@ -92,6 +109,19 @@ if (window.eventSender) { |
| assertChecked('d'); |
| assertNotChecked('e'); |
| assertNotChecked('f'); |
| + |
| + assertNotChecked('אחד'); |
| + assertChecked('שני'); |
| + assertNotChecked('שלוש'); |
| + |
| + getRadio('אחד').focus(); |
| + eventSender.keyDown('downArrow'); |
| + |
| + assertNotChecked('אחד'); |
| + assertChecked('שני'); |
| + assertNotChecked('שלוש'); |
| + |
| + |
| } |
| </script> |
