Chromium Code Reviews Chromium Code Reviews
Issue 1633553002:
Change in focus with movement of Arrow keys for RTL radio buttons (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | |
| 4 <meta charset="UTF-16"> | |
|
tkent
2016/02/08 23:32:26
This file isn't UTF-16. Please remove it.
I don't
chakshu
2016/02/10 10:17:02
Done.
| |
| 5 </head> | |
| 3 <body> | 6 <body> |
| 4 | 7 |
| 5 <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=32013">https://bugs .webkit.org/show_bug.cgi?id=32013</a>. | 8 <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=32013">https://bugs .webkit.org/show_bug.cgi?id=32013</a>. |
| 6 | 9 |
| 7 <p>For manual testing, focus a radio button in the first group and use the arrow keys. Changing the checked | 10 <p>For manual testing, focus a radio button in the first group and use the arrow keys. Changing the checked |
| 8 radio button should fire change events. | 11 radio button should fire change events. |
| 9 | 12 |
| 10 <p> | 13 <p> |
| 11 <input type=radio name=aaa value=a checked onchange="handleChange(event)" onclic k="handleClick(event)">a | 14 <input type=radio name=aaa value=a checked onchange="handleChange(event)" onclic k="handleClick(event)">a |
| 12 <input type=radio name=aaa value=b onchange="handleChange(event)" onclick="handl eClick(event)">b | 15 <input type=radio name=aaa value=b onchange="handleChange(event)" onclick="handl eClick(event)">b |
| 13 <input type=radio name=aaa value=c onchange="handleChange(event)" onclick="handl eClick(event)">c | 16 <input type=radio name=aaa value=c onchange="handleChange(event)" onclick="handl eClick(event)">c |
| 14 | 17 |
| 15 <p>For manual testing, focus a radio button in the second group and use the arro w keys. Change events | 18 <p>For manual testing, focus a radio button in the second group and use the arro w keys. Change events |
| 16 should still be dispatched but the checked radio should not change. | 19 should still be dispatched but the checked radio should not change. |
| 17 | 20 |
| 18 <p> | 21 <p> |
| 19 <input type=radio name=bbb value=d checked onchange="handleChange(event)" onclic k="handleClick(event)">d | 22 <input type=radio name=bbb value=d checked onchange="handleChange(event)" onclic k="handleClick(event)">d |
| 20 <input type=radio name=bbb value=e onchange="handleChange(event)" onclick="handl eClick(event)">e | 23 <input type=radio name=bbb value=e onchange="handleChange(event)" onclick="handl eClick(event)">e |
| 21 <input type=radio name=bbb value=f onchange="handleChange(event)" onclick="handl eClick(event)">f | 24 <input type=radio name=bbb value=f onchange="handleChange(event)" onclick="handl eClick(event)">f |
| 22 | 25 |
| 26 <p>Test for <a href="https://code.google.com/p/chromium/issues/detail?id=556677" >https://code.google.com/p/chromium/issues/detail?id=556677</a>. | |
| 27 | |
| 28 <p>For manual testing, focus a radio button in the first group and use the arrow keys. Changing the | |
| 29 radio button should fire change events in the direction of left to right. | |
| 30 <div dir="auto"> | |
|
tkent
2016/02/08 23:32:26
We'd like to test RTL, so please specify dir=rtl.
chakshu
2016/02/10 10:17:02
Done.
| |
| 31 <p> | |
|
tkent
2016/02/08 23:32:26
This "<p>" looks unnecessary.
chakshu
2016/02/10 10:17:02
This is to separate the radio buttons from the Ass
| |
| 32 <input type="radio" value="אחד" onchange="handleChange(event)" name="r">אחד | |
| 33 <input type="radio" value="שני" onchange="handleChange(event)" name="r">שני | |
| 34 <input type="radio" value="שלוש" onchange="handleChange(event)" name="r">שלוש | |
| 35 </div> | |
| 23 <pre id=out></pre> | 36 <pre id=out></pre> |
| 24 | 37 |
| 25 <script> | 38 <script> |
| 26 | 39 |
| 27 var preventClickValues = 'def'; | 40 var preventClickValues = 'def'; |
| 28 | 41 |
| 29 function handleChange(e) | 42 function handleChange(e) |
| 30 { | 43 { |
| 31 var value = e.target.value; | 44 var value = e.target.value; |
| 32 print(value + ' dispatched change event'); | 45 print(value + ' dispatched change event'); |
| (...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 78 | 91 |
| 79 if (window.eventSender) { | 92 if (window.eventSender) { |
| 80 getRadio('a').focus(); | 93 getRadio('a').focus(); |
| 81 eventSender.keyDown('downArrow'); | 94 eventSender.keyDown('downArrow'); |
| 82 eventSender.keyDown('downArrow'); | 95 eventSender.keyDown('downArrow'); |
| 83 | 96 |
| 84 getRadio('d').focus(); | 97 getRadio('d').focus(); |
| 85 eventSender.keyDown('downArrow'); | 98 eventSender.keyDown('downArrow'); |
| 86 eventSender.keyDown('downArrow'); | 99 eventSender.keyDown('downArrow'); |
| 87 | 100 |
| 101 getRadio('אחד').focus(); | |
|
tkent
2016/02/08 23:32:26
Please move this block just before the first |asse
chakshu
2016/02/10 10:17:02
Done.
| |
| 102 eventSender.keyDown('rightArrow'); | |
| 103 eventSender.keyDown('rightArrow'); | |
| 104 | |
| 88 assertNotChecked('a'); | 105 assertNotChecked('a'); |
| 89 assertNotChecked('b'); | 106 assertNotChecked('b'); |
| 90 assertChecked('c'); | 107 assertChecked('c'); |
| 91 | 108 |
| 92 assertChecked('d'); | 109 assertChecked('d'); |
| 93 assertNotChecked('e'); | 110 assertNotChecked('e'); |
| 94 assertNotChecked('f'); | 111 assertNotChecked('f'); |
| 112 | |
| 113 assertNotChecked('אחד'); | |
| 114 assertChecked('שני'); | |
| 115 assertNotChecked('שלוש'); | |
| 116 | |
| 117 getRadio('אחד').focus(); | |
| 118 eventSender.keyDown('downArrow'); | |
| 119 | |
| 120 assertNotChecked('אחד'); | |
| 121 assertChecked('שני'); | |
| 122 assertNotChecked('שלוש'); | |
| 123 | |
| 124 | |
| 95 } | 125 } |
| 96 | 126 |
| 97 </script> | 127 </script> |
| 98 </body> | 128 </body> |
| 99 </html> | 129 </html> |
| OLD | NEW |
