MacViews: Add native drop shadow to dialogs on OSX < 10.10.

ui/views/bubble/bubble_border.h

Index: ui/views/bubble/bubble_border.h
diff --git a/ui/views/bubble/bubble_border.h b/ui/views/bubble/bubble_border.h
index fac3a719a474b9771fda692b4fad20bfb99a868c..87c0318854512271c5c1150031f6e9e5e2060e9b 100644
--- a/ui/views/bubble/bubble_border.h
+++ b/ui/views/bubble/bubble_border.h
@@ -14,9 +14,12 @@
 #include "ui/views/border.h"
 
 namespace gfx {
+class Path;
 class Rect;
 }
 
+class SkPath;

[tapted, 2016/02/11 01:47:23]

nit: I think this should appear above any forward dec between `namespace`

[karandeepb, 2016/02/11 04:16:04]

Done.

+
 namespace views {
 class Painter;
 
@@ -204,6 +207,13 @@ class VIEWS_EXPORT BubbleBorder : public Border {
   // Gets the arrow offset to use.
   int GetArrowOffset(const gfx::Size& border_size) const;
 
+  // Retreives the arrow path given |view_bounds|. |view_bounds| should be in
+  // its own coordinates (origin at (0,0)).

[tapted, 2016/02/11 01:47:23]

hm - perhaps we should just change GetArrowRect to accept a `const gfx::Size&
view_size` instead of bounds.. bounds may make sense too

Maybe just,

nit: `in its own coordinates` -> `local bounds`

but an owner may have a different opinion.

[karandeepb, 2016/02/11 04:16:04]

Done.

+  // Returns false if |path| is unchanged, which is the case when there is no
+  // painted arrow.
+  // The returned path does not account for arrow stroke and shadow.
+  bool GetArrowPath(const gfx::Rect& view_bounds, gfx::Path* path) const;
+
   // Overridden from Border:
   void Paint(const View& view, gfx::Canvas* canvas) override;
   gfx::Insets GetInsets() const override;
@@ -220,6 +230,8 @@ class VIEWS_EXPORT BubbleBorder : public Border {
   gfx::Size GetSizeForContentsSize(const gfx::Size& contents_size) const;
   gfx::ImageSkia* GetArrowImage() const;
   gfx::Rect GetArrowRect(const gfx::Rect& bounds) const;
+  void GetArrowPathFromArrowBounds(const gfx::Rect& arrow_bounds,
+                                   SkPath* path) const;
   void DrawArrow(gfx::Canvas* canvas, const gfx::Rect& arrow_bounds) const;
 
   internal::BorderImages* GetImagesForTest() const;