MacViews: Add native drop shadow to dialogs on OSX < 10.10.

ui/views/bubble/bubble_border.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
 
 namespace gfx {
+class Path;
 class Rect;
 }
 
+class SkPath;

[tapted, 2016/02/11 01:47:23]

nit: I think this should appear above any forward dec between `namespace`

[karandeepb, 2016/02/11 04:16:04]

Done.

+
 namespace views {
 class Painter;
 
 namespace internal {
 
 // A helper that combines each border image-set painter with arrows and metrics.
 struct BorderImages {
   BorderImages(const int border_image_ids[],
                const int arrow_image_ids[],
                int border_interior_thickness,
@@ skipping 167 matching lines @@
 
   // Get the border exterior thickness, including stroke and shadow, in pixels.
   int GetBorderThickness() const;
 
   // Returns the corner radius of the current image set.
   int GetBorderCornerRadius() const;
 
   // Gets the arrow offset to use.
   int GetArrowOffset(const gfx::Size& border_size) const;
 
+  // Retreives the arrow path given |view_bounds|. |view_bounds| should be in
+  // its own coordinates (origin at (0,0)).

[tapted, 2016/02/11 01:47:23]

hm - perhaps we should just change GetArrowRect to accept a `const gfx::Size&
view_size` instead of bounds.. bounds may make sense too

Maybe just,

nit: `in its own coordinates` -> `local bounds`

but an owner may have a different opinion.

[karandeepb, 2016/02/11 04:16:04]

Done.

+  // Returns false if |path| is unchanged, which is the case when there is no
+  // painted arrow.
+  // The returned path does not account for arrow stroke and shadow.
+  bool GetArrowPath(const gfx::Rect& view_bounds, gfx::Path* path) const;
+
   // Overridden from Border:
   void Paint(const View& view, gfx::Canvas* canvas) override;
   gfx::Insets GetInsets() const override;
   gfx::Size GetMinimumSize() const override;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleBorderTest, GetSizeForContentsSizeTest);
   FRIEND_TEST_ALL_PREFIXES(BubbleBorderTest, GetBoundsOriginTest);
   FRIEND_TEST_ALL_PREFIXES(BubbleBorderTest, ShadowTypes);
 
   // The border and arrow stroke size used in image assets, in pixels.
   static const int kStroke;
 
   gfx::Size GetSizeForContentsSize(const gfx::Size& contents_size) const;
   gfx::ImageSkia* GetArrowImage() const;
   gfx::Rect GetArrowRect(const gfx::Rect& bounds) const;
+  void GetArrowPathFromArrowBounds(const gfx::Rect& arrow_bounds,
+                                   SkPath* path) const;
   void DrawArrow(gfx::Canvas* canvas, const gfx::Rect& arrow_bounds) const;
 
   internal::BorderImages* GetImagesForTest() const;
 
   Arrow arrow_;
   int arrow_offset_;
   ArrowPaintType arrow_paint_type_;
   BubbleAlignment alignment_;
   Shadow shadow_;
   internal::BorderImages* images_;
@@ skipping 14 matching lines @@
 
  private:
   BubbleBorder* border_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleBackground);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_