Move the mini_installer_version rule to its own gyp file.

Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
          mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
                obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                        obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                            obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder

Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc -> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target cause some
important build failures on the official builder.

Defining this target in a new gyp file (instead of in a gypi file) fix this redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
Committed: https://crrev.com/a0ad68e81c795be1fbf4f5125c3dd4fc0d3f918f
Cr-Commit-Position: refs/heads/master@{#371746}

[scottmg, 2016-01-27 00:46:55]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-01-27 00:46:55]

lg enough to me to tbr grt to get it landed tonight :)

[scottmg, 2016-01-27 00:47:14]

A little more description in the description would be good.

[Sébastien Marchand, 2016-01-27 00:59:19]

Description was changed from

==========
Move the mini_installer_version rule to its own gyp file.

BUG=581525
==========

to

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on")

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


BUG=581525
==========

[Sébastien Marchand, 2016-01-27 00:59:19]

sebmarchand@chromium.org changed reviewers:
+ gab@chromium.org, grt@chromium.org

[Sébastien Marchand, 2016-01-27 01:01:38]

Description was changed from

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on")

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


BUG=581525
==========

to

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

[Sébastien Marchand, 2016-01-27 01:04:57]

Description was changed from

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

to

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


Defining this target in a new gyp file (instead of in a gypi file) fix this
redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

[Sébastien Marchand, 2016-01-27 01:30:56]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:33:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633343002/1

[commit-bot: I haz the power, 2016-01-27 01:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:49:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2016-01-27 02:04:54]

Another attempt here https://codereview.chromium.org/1633143004/ because I can't
upload to this issue.

[scottmg, 2016-01-27 02:25:54]

no such luck, going back to the first attempt.

[Sébastien Marchand, 2016-01-27 05:38:58]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-01-27 05:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633343002/40001

[commit-bot: I haz the power, 2016-01-27 06:05:00]

Description was changed from

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


Defining this target in a new gyp file (instead of in a gypi file) fix this
redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

to

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


Defining this target in a new gyp file (instead of in a gypi file) fix this
redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

[commit-bot: I haz the power, 2016-01-27 06:05:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 06:05:55]

Description was changed from

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder



Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.


Defining this target in a new gyp file (instead of in a gypi file) fix this
redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525
==========

to

==========
Move the mini_installer_version rule to its own gyp file.

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
         
mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
               
obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                       
obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                           
obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder

Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc
-> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target
cause some
important build failures on the official builder.

Defining this target in a new gyp file (instead of in a gypi file) fix this
redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525

Committed: https://crrev.com/a0ad68e81c795be1fbf4f5125c3dd4fc0d3f918f
Cr-Commit-Position: refs/heads/master@{#371746}
==========

[commit-bot: I haz the power, 2016-01-27 06:05:55]

Patchset 3 (id:??) landed as
https://crrev.com/a0ad68e81c795be1fbf4f5125c3dd4fc0d3f918f
Cr-Commit-Position: refs/heads/master@{#371746}

[grt (UTC plus 2), 2016-01-27 16:15:34]

nothing obvious jumps out at me, so LGTM if it works.