Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4162)

Unified Diff: chrome/installer/mini_installer.gypi

Issue 1633343002: Move the mini_installer_version rule to its own gyp file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the mini_installer_version target Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | chrome/installer/mini_installer_syzygy.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer.gypi
diff --git a/chrome/installer/mini_installer.gypi b/chrome/installer/mini_installer.gypi
index 3ab2115cb8f342f8d2a19f5c5a7cef5fd5dcb65b..b0373add0c6fad8eea9fba4f8452f3dd15b4d084 100644
--- a/chrome/installer/mini_installer.gypi
+++ b/chrome/installer/mini_installer.gypi
@@ -17,6 +17,7 @@
'../chrome.gyp:default_extensions',
'../chrome.gyp:setup',
'installer_tools.gyp:test_installer_sentinel',
+ 'mini_installer_version.gyp:mini_installer_version',
],
'include_dirs': [
'../..',
@@ -25,6 +26,7 @@
],
'sources': [
'<(INTERMEDIATE_DIR)/packed_files.rc',
+ '<(PRODUCT_DIR)/mini_installer_exe_version.rc',
'mini_installer/appid.h',
'mini_installer/chrome.release',
'mini_installer/chrome_appid.cc',
@@ -135,34 +137,6 @@
# TODO(yukawa): Enable the common compatibility manifest again.
'win_exe_compatibility_manifest': '',
},
- 'rules': [
- {
- 'rule_name': 'mini_installer_version',
- 'extension': 'version',
- 'variables': {
- 'template_input_path': 'mini_installer/mini_installer_exe_version.rc.version',
- },
- 'inputs': [
- '<(template_input_path)',
- '<(version_path)',
- '<(lastchange_path)',
- '<(branding_dir)/BRANDING',
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/mini_installer_exe_version.rc',
- ],
- 'action': [
- 'python', '<(version_py)',
- '-f', '<(version_path)',
- '-f', '<(lastchange_path)',
- '-f', '<(branding_dir)/BRANDING',
- '<(template_input_path)',
- '<@(_outputs)',
- ],
- 'process_outputs_as_sources': 1,
- 'message': 'Generating version information'
- },
- ],
'actions': [
{
'action_name': 'installer_archive',
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | chrome/installer/mini_installer_syzygy.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698