Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1633273002: Fix broken remoting webapp javascript unittest. (Closed)

Created:
4 years, 10 months ago by kelvinp
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken remoting webapp javascript unittest. After forcing tests to fail after a 10 seconds timeout, turns out the spy promise tests are the culprit. I have removed them from our tests as they are originally intended to test XHR's and we now have a better API for that. BUG=582005 Committed: https://crrev.com/aeb109ffd9b79927edb6a75f8cef7e72792fb356 Cr-Commit-Position: refs/heads/master@{#371658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -568 lines) Patch
M chrome/test/remoting/webapp_javascript_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/base/js/dns_blackhole_checker_unittest.js View 7 chunks +7 lines, -7 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/webapp/unittests/spy_promise.js View 1 chunk +0 lines, -294 lines 0 comments Download
D remoting/webapp/unittests/spy_promise_unittest.js View 1 chunk +0 lines, -253 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
kelvinp
PTAL
4 years, 10 months ago (2016-01-26 22:15:14 UTC) #2
Jamie
lgtm
4 years, 10 months ago (2016-01-26 22:18:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633273002/1
4 years, 10 months ago (2016-01-26 23:41:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 00:23:50 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aeb109ffd9b79927edb6a75f8cef7e72792fb356 Cr-Commit-Position: refs/heads/master@{#371658}
4 years, 10 months ago (2016-01-27 00:25:04 UTC) #10
Garrett Casto
4 years, 10 months ago (2016-01-28 00:03:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1643823002/ by gcasto@chromium.org.

The reason for reverting is: This is still quite flaky on Linux. It has failed
the 3 times in a row now.

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests.

Powered by Google App Engine
This is Rietveld 408576698