Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1638753003: Fails QUnit.test() after a timeout of 5 seconds. (Closed)

Created:
4 years, 11 months ago by kelvinp
Modified:
4 years, 10 months ago
Reviewers:
Jamie, battre
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@FixUT
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fails QUnit.test() after a timeout of 5 seconds. Summary of changes: 1. Fails QUnit.test() it doesn't return within 5 seconds. Timing dependent tests should use fake timers instead. 2. Adds an option to disable the timeout when debugging failed tests locally. 3. Logs the current test to the console to ease debugging. NOTRY=true Trybots failing on tests that has already been deleted. Committed: https://crrev.com/ed48a6910aace9ad86ef10c2ecdfeae1bb31a40c Cr-Commit-Position: refs/heads/master@{#371890}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M third_party/qunit/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/qunit/src/browser_test_harness.js View 3 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (23 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/20001
4 years, 11 months ago (2016-01-26 22:57:48 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/171729)
4 years, 11 months ago (2016-01-27 00:15:59 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/40001
4 years, 11 months ago (2016-01-27 00:48:29 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/171799)
4 years, 11 months ago (2016-01-27 01:38:01 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/60001
4 years, 11 months ago (2016-01-27 01:55:22 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/171835)
4 years, 11 months ago (2016-01-27 02:41:13 UTC) #15
kelvinp
On 2016/01/27 02:41:13, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 11 months ago (2016-01-27 18:04:33 UTC) #18
Jamie
lgtm
4 years, 11 months ago (2016-01-27 18:16:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/80001
4 years, 11 months ago (2016-01-27 18:23:54 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/172192)
4 years, 11 months ago (2016-01-27 19:22:51 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/80001
4 years, 11 months ago (2016-01-27 21:55:36 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638753003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638753003/80001
4 years, 11 months ago (2016-01-27 22:07:15 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 11 months ago (2016-01-27 22:15:26 UTC) #33
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ed48a6910aace9ad86ef10c2ecdfeae1bb31a40c Cr-Commit-Position: refs/heads/master@{#371890}
4 years, 11 months ago (2016-01-27 22:17:43 UTC) #35
kelvinp
On 2016/01/27 22:17:43, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 11 months ago (2016-01-27 23:38:19 UTC) #36
kelvinp
A revert of this CL (patchset #2 id:80001) has been created in https://codereview.chromium.org/1642643003/ by kelvinp@chromium.org. ...
4 years, 11 months ago (2016-01-28 01:59:51 UTC) #37
battre
4 years, 11 months ago (2016-01-28 08:38:35 UTC) #39
Message was sent while issue was closed.
Please always reference a bug number in your change list description.

Powered by Google App Engine
This is Rietveld 408576698