Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1633213003: Remove FieldType::Iterator. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove FieldType::Iterator. Field types can contain at most one map, so we can just use IsClass(). Committed: https://crrev.com/639288e1adb33fa7deee9600b31ffa2111bf1506 Cr-Commit-Position: refs/heads/master@{#33533}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -154 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/types.h View 1 2 chunks +0 lines, -27 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-26 22:52:35 UTC) #2
Benedikt Meurer
Nice. LGTM!
4 years, 11 months ago (2016-01-27 05:13:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633213003/20001
4 years, 11 months ago (2016-01-27 05:21:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 05:25:31 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 05:26:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/639288e1adb33fa7deee9600b31ffa2111bf1506
Cr-Commit-Position: refs/heads/master@{#33533}

Powered by Google App Engine
This is Rietveld 408576698